Skip to content

refactor: extract LabeledField wrapper to remove label+input boilerplate (@byseif21)#7784

Merged
Miodec merged 7 commits intomonkeytypegame:masterfrom
byseif21:refactor/labeled-field-component
Apr 8, 2026
Merged

refactor: extract LabeledField wrapper to remove label+input boilerplate (@byseif21)#7784
Miodec merged 7 commits intomonkeytypegame:masterfrom
byseif21:refactor/labeled-field-component

Conversation

@byseif21
Copy link
Copy Markdown
Contributor

@byseif21 byseif21 commented Apr 7, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 7, 2026 16:48
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Apr 7, 2026
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Apr 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extracts a reusable LabeledField wrapper component to reduce repeated “label + field” markup across modals.

Changes:

  • Added LabeledField UI wrapper component in ui/form.
  • Replaced several inline label+field blocks in modals with LabeledField.
  • Minor layout adjustment inside CustomGeneratorModal presets section while refactoring.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
frontend/src/ts/components/ui/form/LabeledField.tsx Introduces reusable labeled wrapper for form controls.
frontend/src/ts/components/modals/WordFilterModal.tsx Refactors multiple labeled inputs/selects to use LabeledField.
frontend/src/ts/components/modals/QuoteSubmitModal.tsx Refactors quote submit fields to use LabeledField.
frontend/src/ts/components/modals/QuoteReportModal.tsx Refactors report fields to use LabeledField.
frontend/src/ts/components/modals/CustomGeneratorModal.tsx Refactors generator inputs to use LabeledField (also changes presets layout markup).

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Apr 8, 2026
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Apr 8, 2026
@Miodec Miodec merged commit 4808050 into monkeytypegame:master Apr 8, 2026
7 checks passed
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Apr 8, 2026
@byseif21 byseif21 deleted the refactor/labeled-field-component branch April 8, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants